Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the Atom JavaScript grammar #8204

Closed
1 task done
aeschli opened this issue Jun 27, 2016 · 4 comments
Closed
1 task done

Test the Atom JavaScript grammar #8204

aeschli opened this issue Jun 27, 2016 · 4 comments
Assignees
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Jun 27, 2016

Several users have asked for syntax highlighting similar to Atom, in particular for variable and function references (not just declarations). I published a extension containing the Atom grammar to try this out.

  • in the extension viewlet search for 'Atom JavaScript Grammar'
@egamma
Copy link
Member

egamma commented Jun 28, 2016

Tested with light/dark themes and also compared with the monokai theme in different editors. The grammar is descent.

@jrieken jrieken closed this as completed Jun 28, 2016
@paulirish
Copy link

Not sure what's going on but the extension is not working well for me.

Here's atom & vscode side by side:

image

@aeschli
Copy link
Contributor Author

aeschli commented Jun 29, 2016

What theme are you using?

@egamma
Copy link
Member

egamma commented Jul 1, 2016

@aeschli @paulirish I can reproduce this when using the Oceanic Next theme. I've filed #8613.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants