Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsed explorer nodes only show up after expanding a folder #84703

Closed
roblourens opened this issue Nov 13, 2019 · 5 comments
Closed

Collapsed explorer nodes only show up after expanding a folder #84703

roblourens opened this issue Nov 13, 2019 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues
Milestone

Comments

@roblourens
Copy link
Member

Is this how it's supposed to work? It makes sense that we don't look inside a folder until it's opened, but it was a little surprising.

Nov-13-2019 09-44-12

@joaomoreno
Copy link
Member

Unfortunately yeah... otherwise we have to call readdir on every rendered folder. Currently we don't. Leaving this to @isidorn.

@isidorn
Copy link
Contributor

isidorn commented Nov 14, 2019

Yeah, it would be a perf hit if we did this. Leavign this open as a feature request for now, and we can decide in the future what to do.

@isidorn isidorn added feature-request Request for new features or functionality file-explorer Explorer widget issues labels Nov 14, 2019
@isidorn isidorn added this to the Backlog Candidates milestone Nov 14, 2019
@isidorn isidorn modified the milestones: Backlog Candidates, Backlog Dec 3, 2019
@jrieken
Copy link
Member

jrieken commented Dec 3, 2019

Honestly - I'd say this is stretching the limits of feature request and I'd say that's how I expect the feature to work/to be defined.

@roblourens
Copy link
Member Author

After using this feature for awhile, I don't think this is necessarily an issue.

@isidorn
Copy link
Contributor

isidorn commented Jul 30, 2020

Closing as dup of #66971
Since it goes in the same direction of resolving all folders before hand

@isidorn isidorn closed this as completed Jul 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues
Projects
None yet
Development

No branches or pull requests

4 participants