Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileSystemProvider: Star activation doesn't work for FileSystemProviders #84799

Closed
joaomoreno opened this issue Nov 14, 2019 · 1 comment
Closed

FileSystemProvider: Star activation doesn't work for FileSystemProviders #84799

joaomoreno opened this issue Nov 14, 2019 · 1 comment
Assignees
@jrieken

Comments

@joaomoreno
Copy link
Member

From #84130

Git is already activated by *. But this doesn't seem to work for its FileSystemProvider. When adding onFileSystem:gitfs to the list of activationEvents it works OK. So it seems that the FileSystemProvider didn't get registered despite the extension activating on anything.

Shouldn't * activated extensions be activated whenever someone calls activateByEvent with any event name?
@joaomoreno joaomoreno mentioned this issue Nov 14, 2019
Merged
2 tasks
@joaomoreno
Copy link
Member Author

Sorry, bad issue! Found the problem in Git extension.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaomoreno @jrieken