-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab dragging should show where the tab will be inserted, not which tab it will be "replacing" #8544
Comments
I think if the tabs support animation it does not need this placeholder. |
As @Tyriar suggests, previewing where the tab will be placed seems like a good approach. Edge does it too, seems like a reasonably common pattern. Visual Studio does something similar, although not as smooth - the tab jumps into place as you drag with the mouse down. I would recommend we do what the browsers do. |
+1 for the browser behavior and dynamic rearranging if possible. |
We agreed in UX sync today that it would be good to get feedback on two different approaches:
|
+1, the current behavior is pretty unintuitive. Of the two options @bgashler1 presented, it seems like option 1 is the way Sublime Text does it and option 2 is the way Atom does it. In my opinion, I would prefer option 1 but either one would be a big improvement. |
The current behaviour is ambiguous and confusing: when you drag a tab and hover over another tab with it, you can't tell whether dropping the tab will put it to the left or the right of the tab. (Sorry for the duplicate!) (Is there a related issue for the dragging behaviour Open Editors list, which has the same problem?) |
I wouldn't say this is crucial, but just about every other UI shows the insertion point when tabs or list items are dragged. This makes VSCode look pretty bad. |
#7854
Currently:
It would be more intuitive for a "to be inserted here" vertical line to show up to the left of code.spec.template.
Dynamic rearranging like in Chrome would be an even nicer visual indicator.
The text was updated successfully, but these errors were encountered: