Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab dragging should show where the tab will be inserted, not which tab it will be "replacing" #8544

Closed
Tyriar opened this issue Jun 29, 2016 · 8 comments
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code ux User experience issues workbench-tabs VS Code editor tab issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2016

#7854

  • VSCode Version: Code - Insiders 1.3.0-insider (798b41a, 2016-06-29T05:14:50.570Z)
  • OS Version: Linux x64 4.4.0-24-generic, Ubuntu 16.04

Currently:

image

It would be more intuitive for a "to be inserted here" vertical line to show up to the left of code.spec.template.

Dynamic rearranging like in Chrome would be an even nicer visual indicator.

@Tyriar Tyriar added ux User experience issues workbench workbench-tabs VS Code editor tab issues labels Jun 29, 2016
@bpasero bpasero added the feature-request Request for new features or functionality label Jun 30, 2016
@bpasero bpasero modified the milestone: Backlog Jun 30, 2016
@bpasero bpasero assigned stevencl and bgashler1 and unassigned bpasero Jul 2, 2016
@yisibl
Copy link
Contributor

yisibl commented Jul 4, 2016

I think if the tabs support animation it does not need this placeholder.

@stevencl
Copy link
Member

stevencl commented Jul 4, 2016

As @Tyriar suggests, previewing where the tab will be placed seems like a good approach. Edge does it too, seems like a reasonably common pattern. Visual Studio does something similar, although not as smooth - the tab jumps into place as you drag with the mouse down.

I would recommend we do what the browsers do.

@bgashler1
Copy link
Contributor

+1 for the browser behavior and dynamic rearranging if possible.

@bgashler1
Copy link
Contributor

bgashler1 commented Jul 6, 2016

We agreed in UX sync today that it would be good to get feedback on two different approaches:

  1. dynamic reordering with animated tabs moving to make room (browser style)
  2. using a vertical bar to indicate the exact position a tab will be inserted.

@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label Aug 29, 2016
@bpasero bpasero removed workbench help wanted Issues identified as good community contribution opportunities labels Nov 16, 2017
@kylevdr
Copy link

kylevdr commented Mar 15, 2018

+1, the current behavior is pretty unintuitive. Of the two options @bgashler1 presented, it seems like option 1 is the way Sublime Text does it and option 2 is the way Atom does it. In my opinion, I would prefer option 1 but either one would be a big improvement.

@joachim-n
Copy link

The current behaviour is ambiguous and confusing: when you drag a tab and hover over another tab with it, you can't tell whether dropping the tab will put it to the left or the right of the tab.

(Sorry for the duplicate!)

(Is there a related issue for the dragging behaviour Open Editors list, which has the same problem?)

@bpasero bpasero added the *out-of-scope Posted issue is not in scope of VS Code label Oct 5, 2021
@joachim-n
Copy link

I wouldn't say this is crucial, but just about every other UI shows the insertion point when tabs or list items are dragged. This makes VSCode look pretty bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code ux User experience issues workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

8 participants
@joachim-n @bpasero @stevencl @Tyriar @yisibl @bgashler1 @kylevdr and others