Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong deDE keybind mapping ( key: "... [" -> key: "... ü" ) #8568

Closed
HatiGamedev opened this issue Jun 30, 2016 · 1 comment
Closed

Wrong deDE keybind mapping ( key: "... [" -> key: "... ü" ) #8568

HatiGamedev opened this issue Jun 30, 2016 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux verified Verification succeeded
Milestone

Comments

@HatiGamedev
Copy link

  • VSCode Version: 1.2.1 ( 2016-06-14T12:54:38.105Z )
  • OS Version: Arch Linux 4.4.14-1-lts
  • Keyboard Layout: de

Problem:

VSCode shows that the keybinding is mapped to shift+k ü, If i press this it says no shortcut available.
However shift+k ß the so defined shortcut works.

Steps to Reproduce:

  1. Add keybinding { key: "shift+k [", command: "cursorRight" }
  2. Test in any Text-editor (expected to move right on shift+k ü as shown rather than shift+k ß)
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Jun 30, 2016
@alexdima alexdima added the keybindings VS Code keybinding issues label Aug 9, 2016
@alexdima alexdima added this to the Backlog milestone Aug 9, 2016
@alexdima alexdima added the keyboard-layout Keyboard layout issues label Mar 1, 2017
@alexdima alexdima added the linux Issues with VS Code on Linux label Mar 13, 2017
@alexdima
Copy link
Member

I have validated that we now (i.e. after PR #22894 aka #17521 -- in tomorrow's Insiders build) appear to behave correctly for this keyboard layout

image


Analysis of key code binding shift+k [

  • I have added the rule { "key": "shift+k [", "command": "cursorRight" } to my keybindings.json
  • the key code binding shift+k is mapped to scan code binding Shift+[KeyK] (I will not go to great detail to explain why, the reason is that [KeyK] produces k)
  • the key code binding [ is more interesting.
  • [ can be produced through a single scan code combination: Ctrl+Alt+[Digit8]. i.e.:
    image
  • therefore, the key code binding [ is mapped to the scan code combination Ctrl+Alt+[Digit8]
  • this is now correctly reflected in the info hover:
    image
    image

Analysis of pressing [Minus]

image

We now correctly label it:
image

And it is possible to bind it to the desired command e.g. with following keybinding rule:

{ "key": "shift+k [minus]", "command": "cursorRight" }

VS Code will now also correctly label it in the info tooltip:
image


This makes me believe the fix in PR #22894 aka #17521 resolves this issue. Please double check in tomorrow's insiders build.

@alexdima alexdima modified the milestones: March 2017, Backlog Mar 23, 2017
@roblourens roblourens reopened this Mar 31, 2017
@roblourens roblourens added the verified Verification succeeded label Mar 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants