Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search/filter in debug pane #86369

Closed
Zingam opened this issue Dec 5, 2019 · 9 comments
Closed

Add search/filter in debug pane #86369

Zingam opened this issue Dec 5, 2019 · 9 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) *question Issue represents a question, should be posted to StackOverflow (VS Code)

Comments

@Zingam
Copy link

Zingam commented Dec 5, 2019

I think all panes which have hierarchical trees like the debug pane could have an option/search box to quickly search for an element by name. So by typing a part the name the tree will filter out and display only the matching elements.

@vscodebot vscodebot bot added the search Search widget and operation issues label Dec 5, 2019
@gjsjohnmurray
Copy link
Contributor

Did you already try simply typing while focus is on the Variables pane?

@roblourens roblourens assigned isidorn and unassigned roblourens Dec 5, 2019
@roblourens roblourens removed the search Search widget and operation issues label Dec 5, 2019
@Zingam
Copy link
Author

Zingam commented Dec 6, 2019

@gjsjohnmurray Thank you for pointing me to this feature. I didn't know about it and it isn't a very intuitive UI feature. I could be more explicit.
Also it doesn't really work in the way I suggest: It is only good for non-hierarchical lists. For example if there are a multiple items in a collapsed hierarchical view in the debug pane, typing the searched item name would neither expand and point to it nor will it hide the unwanted items. So it isn't really very useful at first try.

It works well enough if I search for C functions in the outliner but it doesn't work well at all if I search for TypeScript object/member names in the debugger pane and it isn't intuitive for me.

@gjsjohnmurray
Copy link
Contributor

gjsjohnmurray commented Dec 6, 2019

@Zingam I agree it's a feature that deserves better discoverability. You may want to upvote #70646 and/or #72119

Did you notice that if you mouse over the little widget that appeared when you started typing, there are a couple of extra things you can do?

image

One of them it to toggle to "filter" mode in place of "highlight" mode.

@isidorn
Copy link
Contributor

isidorn commented Dec 6, 2019

Thanks @gjsjohnmurray
Closing this as a question / duplicate then

@isidorn isidorn added *duplicate Issue identified as a duplicate of another issue(s) *question Issue represents a question, should be posted to StackOverflow (VS Code) labels Dec 6, 2019
@vscodebot
Copy link

vscodebot bot commented Dec 6, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@isidorn isidorn closed this as completed Dec 6, 2019
@vscodebot
Copy link

vscodebot bot commented Dec 6, 2019

Please ask your question on StackOverflow. We have a great community over there. They have already answered thousands of questions and are happy to answer yours as well. See also our issue reporting guidelines.

Happy Coding!

@Zingam
Copy link
Author

Zingam commented Dec 6, 2019

@gjsjohnmurray Thank you for letting me know about the widgets.

@isidorn The filtering still doesn't work quite as expected. I'd like that it would expand the hierarchy and show the searched item. Also it is buggy in the current state, please check the last screenshot: I have typed 'flat' and it also includes defaultTargetName in the results. Also on the previous screenshot: there is also an item that shouldn't be there

Capture3
Capture2
Capture1
Capture4
Capture5

@Zingam
Copy link
Author

Zingam commented Dec 6, 2019

Why is the ctx displayed in the search results? The tree filter seems to be broken.

image

@gjsjohnmurray
Copy link
Contributor

@Zingam because it uses the same fuzzy matching as other parts of VSCode do. You may want to upvote #66913

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) *question Issue represents a question, should be posted to StackOverflow (VS Code)
Projects
None yet
Development

No branches or pull requests

4 participants