Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigating collecting feedback when a user restarts the TS Server #88315

Closed
mjbvz opened this issue Jan 8, 2020 · 5 comments
Closed

Investigating collecting feedback when a user restarts the TS Server #88315

mjbvz opened this issue Jan 8, 2020 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality javascript JavaScript support issues *out-of-scope Posted issue is not in scope of VS Code typescript Typescript support issues
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 8, 2020

Background

Normal users should never need to use the Restart TS Server command. However we see around 1500 or so unique sessions a day where people invoke this command. Restarting the TS server is a pretty good indication that something has gone wrong from the user's point of view

Investigation

See if there is a way for us to collect user feedback when they restart the TS server.

For example, if a user restarts the server X number of times in a season (over over Z number of days), then show a prompt asking for feedback

/cc @DanielRosenwasser

@mjbvz mjbvz added this to the On Deck milestone Jan 8, 2020
@mjbvz mjbvz self-assigned this Jan 8, 2020
@mjbvz mjbvz added javascript JavaScript support issues typescript Typescript support issues labels Jan 8, 2020
@mjbvz mjbvz added the feature-request Request for new features or functionality label Nov 3, 2020
@schickling
Copy link

schickling commented Dec 7, 2021

Two major reasons I'm resorting to having to restart the TS server regularly:

  1. After (re-)generating code files containing type definitions (e.g. see this issue). (Maybe this is a particular problem when generating code/types into node_modules/.somepkg?)
  2. Sometimes after upgrading NPM dependencies

Regarding solutions: In order to address (1) it would be great if it was possible for tools that generate code/types (e.g. Prisma) to "ping" the TS LSP in order to let it know that certain files have been modified/touched. (It seems that the Prisma VSC extension already does this in a crude way by simply triggering a TS server restart when files a re-generated.)

Personal note: For me personally (and I know of many others) this is one of the biggest annoyances of TypeScript in day to day development. I've been joking to remap my F5 key from page refresh to Restart TS server. 🤪

cc @orta

@orta
Copy link
Contributor

orta commented Dec 7, 2021

It's worth noting that this ^ is specifically about files which are changed by tools inside the node_modules folder and do not get picked up by the watcher

@OliverJAsh
Copy link
Contributor

I often need to restart the server when switching branches. I shared a reduced test case for this here: microsoft/TypeScript#44066

@FishOrBear

This comment was marked as off-topic.

@mjbvz mjbvz added the *out-of-scope Posted issue is not in scope of VS Code label Dec 5, 2022
@vscodenpa
Copy link

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality javascript JavaScript support issues *out-of-scope Posted issue is not in scope of VS Code typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

6 participants