Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to implement WorkspaceSymbolProvider with only offset information? #890

Closed
lukehoban opened this issue Dec 1, 2015 · 4 comments · Fixed by #10062
Closed
Assignees
Labels
api feature-request Request for new features or functionality
Milestone

Comments

@lukehoban
Copy link
Contributor

It appears that it's not really possible to implement WorkspaceSymbolProvider if all you have available from the underlying language analysis engine is offset information (vs. line/col).

The vscode API requires that you provide line/col for every reference up front, which would require opening every file and mapping position information.

Questions:

  1. Could the vscode API allow passing offset information instead of line/col in this case?
  2. Could the vscode API allow a callback that computes line/col (after providing a TextDocument) instead of providing it up-front, since the UX doesn't need this info until after the user chooses to navigate to a reference?
  3. Is there any way to work around this?
@jrieken
Copy link
Member

jrieken commented Dec 2, 2015

Fair request, no workaround as of today. Needs some thinking as this might be an issue in several places...

@jrieken
Copy link
Member

jrieken commented Jul 13, 2016

@aeschli Is this urgent?

@jrieken jrieken added the feature-request Request for new features or functionality label Jul 13, 2016
@aeschli
Copy link
Contributor

aeschli commented Jul 13, 2016

@jrieken No rush, we don't have any deadlines yet, but it would be great to have it in one of the next milestones.

@jrieken
Copy link
Member

jrieken commented Aug 3, 2016

@lukehoban Not sure if this is still relevant for vcode-go but you can do option #2

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants