Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression 1.3] Command palette no longer mouse-accessible #8913

Closed
edwardgalligan opened this issue Jul 8, 2016 · 5 comments
Closed

[Regression 1.3] Command palette no longer mouse-accessible #8913

edwardgalligan opened this issue Jul 8, 2016 · 5 comments
Assignees
Labels
ux User experience issues
Milestone

Comments

@edwardgalligan
Copy link

  • VSCode Version: 1.3
  • OS Version: various

Steps to Reproduce:

  1. Click the filename of the currently open file (at the top of the editor pane)
  2. Nothing happens (previously the Command Palette opened)

This is related to my previously opened Feature Request: #8576 in which I requested that this functionality would also work on a blank screen (with no editor open). However, now with the 1.3 update it appears the functionality has disappeared completely in all contexts.

Note: I have "workbench.editor.showTabs" set to false since 1.3 to match the (far superior) pre-1.3 functionality.

@bpasero
Copy link
Member

bpasero commented Jul 8, 2016

I took it out because we also don't have it when tabs are enabled. Maybe we should open this to the context menu on tabs and the file name?

@bpasero bpasero added the ux User experience issues label Jul 8, 2016
@edwardgalligan
Copy link
Author

edwardgalligan commented Jul 8, 2016

Just to give a bit more context: the primary use case here is switching between files in the history with the mouse (both for this, and also for #8576)

  • Click top-left
  • See file history dropdown list
  • Click file in list

There's no need to type, so no need to move from mouse to keyboard. So losing this (i.e. having to switch to keyboard to trigger a shortcut to open the dropdown) is a major usability regression for mouse use.

This is possibly mitigated by using tabs, but I think the previous paradigm of history navigation (with this dropdown feature available via mouse) was far more usable than the new tabbed interface.

Re-introducing any way to open the history dropdown with a single mouseclick, without keyboard usage, would be great.

Note: This mouse-click opened the command palette without the > character pre-typed - i.e. equivalent to Ctrl-P. Ctrl-P isn't available at all in the View menu (only Ctrl-Shift-P is, which pre-populates with >), so there's literally no way to access this feature at all with just a mouse anymore, even with multiple clicks.

@bgashler1
Copy link
Contributor

Thanks for the feedback.

@bpasero we could talk more about this at UX sync, but just as an initial idea, could we distinguish between one click and a double click on just the file name (for tabs-disabled only)? If so, a single click could open the recent files list, and we could still use the double click to "Keep Editor." I think it's worth adding back myself, because I actually remember using it myself before we introduced tabs.

@bpasero
Copy link
Member

bpasero commented Jul 8, 2016

That is up for discussion because initially we wanted to make the file name area rich and clickable to do some actions on it when tabs are disabled. however, this did not make it into the release and we might need to revisit what to do then. note that this does not help in the case where tabs are enabled.

@bgashler1
Copy link
Contributor

UX Meeting Summary:
We will add this functionality back for tabs-disabled, as it was before tabs were introduced.

@bpasero bpasero added this to the July 2016 milestone Jul 14, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants