Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test TypeScript/JavaScript semantic highlighting #89351

Closed
2 tasks done
aeschli opened this issue Jan 27, 2020 · 1 comment
Closed
2 tasks done

Test TypeScript/JavaScript semantic highlighting #89351

aeschli opened this issue Jan 27, 2020 · 1 comment

Comments

@aeschli
Copy link
Contributor

aeschli commented Jan 27, 2020

Testing #77140

Complexity: 4


Semantic highlighting has been added for JavaScript and TypeScript.
All identifiers are classified on the type of the underlying symbol:

  • class, enum, interface, namespace, typeParameter, type, parameter, variable, property, function, member

Additionally, the following modifiers are added:

  • declaration (when the symbol is declared at that location), static, async, readonly

There hasn't been any changes to our built-in themes to show information that hasn't been shown before. But highlighting has changed for the cases where symbols were variables but are now classified as a type or a namespace. E.g. mports now highlight according to the type of the identifier

  • test various files with and without semantic highlighting, look at the differences and verify that the user experience is better, not worse.
  • use the Developer: Inspect Editor Token and Scopes tool to see what style has been given to a token. The hover also shows the textmate scopes at the location and what the old style would have been.
  • use "editor.semanticHighlighting.enabled": false to turn off semantic highlighting

Test classification:

  • Poke around and check whether some identifiers are missed or maybe are even wrong. This get interesting when an identifier represents both a type and a namespace.
  • Verify that JSX element get no semantic highlighting
@aeschli aeschli added this to the January 2020 milestone Jan 27, 2020
@aeschli aeschli changed the title Test TypeScipt/JavaScript semantic highlighting Test TypeScript/JavaScript semantic highlighting Jan 27, 2020
@JacksonKearl JacksonKearl removed their assignment Jan 28, 2020
@JacksonKearl
Copy link
Contributor

Looks good to me

@RMacfarlane RMacfarlane removed their assignment Jan 28, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants