Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test resolveDebugConfigurationWithSubstitutedVariables hook #89375

Closed
1 task done
weinand opened this issue Jan 27, 2020 · 1 comment
Closed
1 task done

Test resolveDebugConfigurationWithSubstitutedVariables hook #89375

weinand opened this issue Jan 27, 2020 · 1 comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone
January 2020

Comments

@weinand
Copy link
Contributor

weinand commented Jan 27, 2020 •
edited by connor4312
Loading

Refs: #87450

Complexity: 3

We've introduced a new DebugConfigurationProvider hook resolveDebugConfigurationWithSubstitutedVariables that receives the debug configurations with all variables resolved.

For verification either create a new extension or modify an existing extension and implement the resolveDebugConfigurationWithSubstitutedVariables hook of a registered DebugConfigurationProvider.

Verify that:

  • all variable types (simple, 'env', 'command', 'input', 'settings') are resolved properly.
  • new variables introduced in the resolveDebugConfiguration hook are resolved in the resolveDebugConfigurationWithSubstitutedVariables hook.
  • returning undefined or null results in the specified behavior.
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item labels Jan 27, 2020
@weinand weinand added this to the January 2020 milestone Jan 27, 2020
@connor4312 connor4312 self-assigned this Jan 27, 2020
@connor4312
Copy link
Member

lgtm, didn't run into any issues

@connor4312 connor4312 removed their assignment Jan 28, 2020
@gjsjohnmurray gjsjohnmurray mentioned this issue Feb 20, 2020
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Milestone
January 2020
Development

No branches or pull requests
3 participants
@weinand @connor4312 and others