-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folding button icons are reversed #89894
Comments
They are functioning as designed. When #79130 arrives you will be able to change them. I suggest you upvote that issue and close this one. |
Source? |
@misolori |
Agreed that this by design and matches other paradigms where |
This is a button icon and the primary function is not to indicate the state. It is to indicate the button function which is to change the state and hence. as in Visual Studio and every other folding editor I have seen, the icon for the collapse command button should depict collapse - not expand as currently.
Not any trees in your standard dialogs on Windows, note. E.g. And what's the source of that screenshot? The button icons do not accord with those I see on Windows (added to root post). Mac perhaps? |
@chrisjj the screenshot above is Chrome dev tools. When I mentioned that we use this treatment in all of our trees, I meant the VS Code product: And a few other examples that use the same paradigm: |
Whereas the folding button icons normally used on source editors (including VS Code, according to the docs) logically depict the effect of a click ([+] to expand, [-] to collapse), the ones actually present in the VS Code program are illogically reversed - the button to expand has the icon ">" depicting collapse, and the button to collapse has the icon "v" depicting expand.
">" and "v" icons are shown here:
The text was updated successfully, but these errors were encountered: