Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folding button icons are reversed #89894

Closed
chrisjj opened this issue Feb 3, 2020 · 6 comments
Closed

Folding button icons are reversed #89894

chrisjj opened this issue Feb 3, 2020 · 6 comments
Labels
*as-designed Described behavior is as designed

Comments

@chrisjj
Copy link

chrisjj commented Feb 3, 2020

Whereas the folding button icons normally used on source editors (including VS Code, according to the docs) logically depict the effect of a click ([+] to expand, [-] to collapse), the ones actually present in the VS Code program are illogically reversed - the button to expand has the icon ">" depicting collapse, and the button to collapse has the icon "v" depicting expand.

">" and "v" icons are shown here:

image

@gjsjohnmurray
Copy link
Contributor

They are functioning as designed. When #79130 arrives you will be able to change them. I suggest you upvote that issue and close this one.

@chrisjj
Copy link
Author

chrisjj commented Feb 3, 2020

They are functioning as designed.

Source?

@gjsjohnmurray
Copy link
Contributor

@misolori

@miguelsolorio
Copy link
Contributor

Agreed that this by design and matches other paradigms where > indicates a collapsed state. We also use this treatment in all of our trees. As @gjsjohnmurray mentioned, you can upvote #79130 if you want custom icons. I'll be closing this one.

image

@miguelsolorio miguelsolorio added the *as-designed Described behavior is as designed label Feb 3, 2020
@chrisjj
Copy link
Author

chrisjj commented Feb 3, 2020

matches other paradigms where > indicates a collapsed state.

This is a button icon and the primary function is not to indicate the state. It is to indicate the button function which is to change the state and hence. as in Visual Studio and every other folding editor I have seen, the icon for the collapse command button should depict collapse - not expand as currently.

We also use this treatment in all of our trees.

Not any trees in your standard dialogs on Windows, note. E.g.

image

And what's the source of that screenshot? The button icons do not accord with those I see on Windows (added to root post). Mac perhaps?

@miguelsolorio
Copy link
Contributor

@chrisjj the screenshot above is Chrome dev tools. When I mentioned that we use this treatment in all of our trees, I meant the VS Code product:

VS Code explorer
image

And a few other examples that use the same paradigm:

Windows explorer
image

Outlook
image

Sublime
image

Atom
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

3 participants