Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown preview jumps a bit on every keystroke #89930

Closed
alexdima opened this issue Feb 3, 2020 · 3 comments
Closed

Markdown preview jumps a bit on every keystroke #89930

alexdima opened this issue Feb 3, 2020 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented Feb 3, 2020

Issue Type: Bug

  • have a markdown preview to the side
  • type in the .md file
  • the preview jumps a bit on each keystroke

TO_UPLOAD

VS Code version: Code - Insiders 1.42.0-insider (be0aca7, 2020-01-31T14:45:49.503Z)
OS version: Windows_NT ia32 10.0.18362

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels Feb 25, 2020
@mjbvz mjbvz added this to the Backlog milestone Oct 2, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 2, 2020

This is related to how the markdown is syncing the scroll. Some points of interest:

  1. This code runs in the markdown preview (which is a webview):

    /*---------------------------------------------------------------------------------------------

  2. Look at where function such as scrollToRevealSourceLine are being called from

To build the markdown preview (after changing any file under preview-src):

  1. cd extensions/typescript-language-featutes
  2. yarn run build-preview

@meganrogge
Copy link
Contributor

@mjbvz There isn't a script called build-preview in the extensions/typescript-language-features package.json.

Also, I can't re-produce this issue.

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 1, 2021

Should be fixed by 8f672ca

recording (2)

There are likely still a few edge cases where it won't work perfectly, but the original example and other tests in vscode-docs worked for me

@mjbvz mjbvz closed this as completed Nov 1, 2021
@meganrogge meganrogge added the verified Verification succeeded label Dec 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants