Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extensions to contribute a command to viewContainer title bar #90268

Closed
ejizba opened this issue Feb 8, 2020 · 7 comments
Closed

Allow extensions to contribute a command to viewContainer title bar #90268

ejizba opened this issue Feb 8, 2020 · 7 comments
Assignees
Labels
api feature-request Request for new features or functionality tree-views Extension tree view issues workbench-views Workbench view issues

Comments

@ejizba
Copy link

ejizba commented Feb 8, 2020

Rather than contribute a command at the "view" level which is possible today, we want to contribute a command at the "viewContainer" level. In our scenario, we're trying to clean up duplicate subscription nodes in the Azure views:
Screen Shot 2020-02-07 at 4 31 02 PM

I would love to have a dropdown that shows the current subscription, but would also settle for a simple button:
Screen Shot 2020-02-07 at 4 33 01 PM Screen Shot 2020-02-07 at 4 36 26 PM

It seems like other viewContainers not contributed by extensions already support this, like Debug and Remote:
Screen Shot 2020-02-07 at 4 04 25 PM
Screen Shot 2020-02-07 at 4 25 32 PM

cc @fiveisprime

@eamodio eamodio assigned sandy081 and jrieken and unassigned sandy081 Feb 8, 2020
@jrieken jrieken removed their assignment Feb 10, 2020
@sandy081 sandy081 added workbench-views Workbench view issues tree-views Extension tree view issues labels Feb 10, 2020
@sandy081 sandy081 added this to the Backlog milestone Feb 10, 2020
@sandy081 sandy081 added the api label Feb 10, 2020
@miguelsolorio
Copy link
Contributor

We also have #89243 regarding using the dropdown in the sidebar header

@gjsjohnmurray
Copy link
Contributor

#110218 would combine well with this, allowing a contributed command to produce a submenu of your subscriptions. So you may like to upvote it.

@gplumb
Copy link

gplumb commented Feb 20, 2021

How can we go about re-opening this issue?

@gjsjohnmurray
Copy link
Contributor

@gplumb if #108271 makes some progress perhaps it will get generalized beyond just the Explorer.

cc @eamodio @isidorn

@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality tree-views Extension tree view issues workbench-views Workbench view issues
Projects
None yet
Development

No branches or pull requests

8 participants
@gplumb @jrieken @gjsjohnmurray @sandy081 @ejizba @miguelsolorio @alexr00 and others