Sync: Failed to sync extension enablement

[joaomoreno]

Testing #91226 on Windows

I reprod this twice and then never again:

1. Machine A: disable a theme
2. Machine B: wait for it to be disabled due to sync, then re-enable it

Machine A would not see it re-enabled, no matter how long I waited.

Sorry for the poor steps... I was able to repro this with normal extensions (ESLint) as well as built-in (Monokai theme).

[sandy081]

@joaomoreno Can you please provide the sync log from both machines while this happening ?

[roblourens]

I also reproed this multiple times. I repro it often if I change multiple extensions enablement at the same time. Here I started with Gitlens and Java disabled in both windows, then enabled both in window A, but in window B, only Gitlens is enabled.

Window A:

[2020-02-25 16:05:34.660] [userDataSync] [info] Auto Sync: Triggered.
[2020-02-25 16:05:34.725] [userDataSync] [info] Settings: No changes found during synchronizing settings.
[2020-02-25 16:05:34.726] [userDataSync] [info] Keybindings: No changes found during synchronizing keybindings.
[2020-02-25 16:05:34.727] [userDataSync] [info] UI State: No changes found during synchronizing ui state.
[2020-02-25 16:05:34.949] [userDataSync] [info] Extensions: Updated remote extensions
[2020-02-25 16:05:34.968] [userDataSync] [info] Extensions: Updated last synchronized extensions
[2020-02-25 16:05:34.969] [userDataSync] [info] Sync done. Took 309ms

Window B:

[2020-02-25 16:05:36.399] [userDataSync] [info] Auto Sync: Triggered.
[2020-02-25 16:05:36.463] [userDataSync] [info] Settings: No changes found during synchronizing settings.
[2020-02-25 16:05:36.468] [userDataSync] [info] Keybindings: No changes found during synchronizing keybindings.
[2020-02-25 16:05:36.470] [userDataSync] [info] UI State: No changes found during synchronizing ui state.
[2020-02-25 16:05:36.799] [userDataSync] [info] Extensions: Enabled extension eamodio.gitlens 10.2.1
[2020-02-25 16:05:36.817] [userDataSync] [info] Extensions: Updated last synchronized extensions
[2020-02-25 16:05:36.817] [userDataSync] [info] Sync done. Took 418ms
[2020-02-25 16:05:38.805] [userDataSync] [info] Auto Sync: Triggered.
[2020-02-25 16:05:38.857] [userDataSync] [info] Settings: No changes found during synchronizing settings.
[2020-02-25 16:05:38.858] [userDataSync] [info] Keybindings: No changes found during synchronizing keybindings.
[2020-02-25 16:05:38.859] [userDataSync] [info] UI State: No changes found during synchronizing ui state.
[2020-02-25 16:05:38.891] [userDataSync] [info] Extensions: No changes found during synchronizing extensions.
[2020-02-25 16:05:38.891] [userDataSync] [info] Sync done. Took 86ms

[sandy081]

Assigning to feb for investigation

[sandy081]

@bpasero here is the code that is not sending storage change event when a key is removed from storage

vscode/src/vs/platform/storage/node/storageIpc.ts

Lines 105 to 107 in fed69ad

	if (typeof existing === 'string') {
	items.set(event.key, existing);
	}

Commit af9dddd introduced this.

[sandy081]

This should be fixed by #91582