Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe '.sync' folder shouldn't be dot-prefixed #91486

Closed
roblourens opened this issue Feb 25, 2020 · 6 comments
Closed

Maybe '.sync' folder shouldn't be dot-prefixed #91486

roblourens opened this issue Feb 25, 2020 · 6 comments
Assignees
@sandy081
Labels
settings-sync verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2020

Comments

@roblourens
Copy link
Member

Testing #91226

I don't see why the .sync folder is not just named sync? I think the . implies that it is private or not something the user cares about but it is just user data

image
@sandy081 sandy081 added the *as-designed Described behavior is as designed label Feb 26, 2020
@sandy081
Copy link
Member

Yes. It is private data maintained by sync feature.

@vscodebot
Copy link

vscodebot bot commented Feb 26, 2020

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Feb 26, 2020
@Tyriar
Copy link
Member

Tyriar commented Feb 27, 2020 •
edited
Loading

I kind of agree with @roblourens; globalStorage and workspaceStorage are also private data maintained by a feature in VS Code? Dot files are also a Nix* concept (that only came about because of a bug in a shell I think) which we shouldn't need to being in to a pretty hidden config folder. Let's chat about this tomorrow.

@Tyriar Tyriar reopened this Feb 27, 2020
@sandy081 sandy081 added settings-sync under-discussion Issue is under discussion for relevance, priority, approach and removed *as-designed Described behavior is as designed labels Feb 27, 2020
@sandy081 sandy081 added this to the February 2020 milestone Feb 27, 2020
@sandy081 sandy081 mentioned this issue Feb 27, 2020
Closed
6 tasks
@sandy081 sandy081 removed the under-discussion Issue is under discussion for relevance, priority, approach label Feb 27, 2020
@sandy081
Copy link
Member

Changed .sync folder to sync and also removed other dot notations .lastSync${area}.json to lastSync${area}.json.

There should not be any impact.

@sandy081 sandy081 added the verification-needed Verification of issue is requested label Feb 27, 2020
@Tyriar
Copy link
Member

Tyriar commented Feb 28, 2020

I saw this but that's just because I hadn't changed my account type. The error is descriptive enough already (since a sync didn't happen yet):

Screen Shot 2020-02-28 at 7 42 42 AM

@Tyriar Tyriar added the verified Verification succeeded label Feb 28, 2020
@sandy081
Copy link
Member

sandy081 commented Mar 2, 2020

I guess you saw this when you are trying to open backups? Yes it happened because sync did not happen yet.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
settings-sync verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
3 participants
@roblourens @Tyriar @sandy081