ILinksList.dispose is never called

[akosyakov]

We use it via Monaco and it's never called. Looking at the code, links are used only here:

vscode/src/vs/editor/contrib/links/getLinks.ts

Line 77 in b0be067

const newLinks = list.links.map(link => new Link(link, provider));

but not dispose method. And then provider itself is registered as disposable, although LinkProvider does not have dispose method.

Do we overlook anything? If not it would mean that

vscode/src/vs/workbench/api/browser/mainThreadLanguageFeatures.ts

Lines 473 to 477 in 3de5a8a

	dispose: () => {
	if (typeof dto.id === 'number') {
	this._proxy.$releaseDocumentLinks(handle, dto.id);
	}
	}

is never called either and the extension host process leaking links.

[jrieken]

It's called here via this. Please add a repro sample

[akosyakov]

It is reproducible with any tsconfig.json file with links.

You are right, provider is added as disposable, but only if it is disposable. Instead the original links list should be added:

When dispose is called, disposable storage is empty:

[jrieken]

You are right, provider is added as disposable, but only if it is disposable.

🤦‍♂ D'oh... Yes this shouldn't be the provider but the result of it...