Notification button goes out of dom when progress changes

[joaomoreno]

When verifying #91469 (comment), there was once that I clicked the Cancel button and nothing happened. I was able to reliably reproduce by holding mouse down, waiting for progress to change and releasing the mouse button.

[bpasero]

This is because I call List#splice() whenever I update progress. I could not figure out a better way how to directly update progress within a list item as far as I remember.

/duplicate of #50931

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

[bpasero]

I remember why: if you update the message text, the height might change due to wrapping. As such I splice the notification, but maybe there is now a better way with newer API?

Code:

vscode/src/vs/workbench/browser/parts/notifications/notificationsToasts.ts

Line 211 in 4f232ba

notificationList.updateNotificationsList(0, 1, [item]);

[joaomoreno]

@bpasero Actually this would be exactly what you could use! cc @rebornix

[bpasero]

@joaomoreno oh nice, will wait for that to land then.