Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[json] support "$id" references. #92042

Closed
rbuckton opened this issue Mar 4, 2020 · 1 comment
Closed

[json] support "$id" references. #92042

rbuckton opened this issue Mar 4, 2020 · 1 comment
Assignees
@aeschli
Labels
feature-request Request for new features or functionality json JSON support issues on-testplan
Milestone
November 2021

Comments

@rbuckton
Copy link
Member

rbuckton commented Mar 4, 2020

The relevant documentation for $id can be found here: https://json-schema.org/understanding-json-schema/structuring.html#using-id-with-ref

  • Version: 1.43.0-insider (user setup)
  • Commit: 17c6d12
  • Date: 2020-02-28T12:46:02.355Z
  • Electron: 7.1.11
  • Chrome: 78.0.3904.130
  • Node.js: 12.8.1
  • V8: 7.8.279.23-electron.0
  • OS: Windows_NT x64 10.0.18362

Steps to Reproduce:

image

This validates correctly using ajv@6.6.2.

Does this issue occur when all extensions are disabled?: Yes
@aeschli aeschli added json JSON support issues feature-request Request for new features or functionality labels Mar 5, 2020
@aeschli aeschli added this to the Backlog milestone Mar 5, 2020
@aeschli aeschli changed the title [json] JSON schema validation fails to support "$id" references. [json] support "$id" references. Mar 5, 2020
@aeschli aeschli modified the milestones: Backlog, March 2020 Mar 5, 2020
@aeschli aeschli modified the milestones: March 2020, April 2020 Mar 30, 2020
@aeschli aeschli mentioned this issue Apr 15, 2020
Closed
@aeschli aeschli modified the milestones: April 2020, May 2020 Apr 27, 2020
@aeschli aeschli mentioned this issue May 13, 2020
Closed
@aeschli aeschli modified the milestones: May 2020, June 2020 Jun 2, 2020
@aeschli aeschli modified the milestones: June 2020, July 2020 Jun 29, 2020
@aeschli aeschli modified the milestones: July 2020, On Deck Aug 2, 2020
@mati-o mati-o mentioned this issue Sep 29, 2021
Merged
@aeschli aeschli modified the milestones: On Deck, November 2021 Nov 16, 2021
@egamma egamma mentioned this issue Nov 22, 2021
Closed
82 tasks
@aeschli
Copy link
Contributor

aeschli commented Nov 29, 2021

Implemented by microsoft/vscode-json-languageservice#107

@aeschli aeschli closed this as completed Nov 29, 2021
@aeschli aeschli added the verification-needed Verification of issue is requested label Nov 29, 2021
@aeschli aeschli mentioned this issue Nov 29, 2021
Closed
1 task
@aeschli aeschli removed the verification-needed Verification of issue is requested label Nov 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
feature-request Request for new features or functionality json JSON support issues on-testplan
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
2 participants
@rbuckton @aeschli