Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer should show hidden files and their path if they are opened #92090

Closed
isidorn opened this issue Mar 5, 2020 · 5 comments
Closed

Explorer should show hidden files and their path if they are opened #92090

isidorn opened this issue Mar 5, 2020 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues on-release-notes Issue/pull request mentioned in release notes on-testplan
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 5, 2020

No description provided.

@isidorn isidorn added feature-request Request for new features or functionality file-explorer Explorer widget issues labels Mar 5, 2020
@isidorn isidorn added this to the March 2020 milestone Mar 5, 2020
@isidorn isidorn self-assigned this Mar 5, 2020
@isidorn isidorn closed this as completed in 1876b51 Mar 9, 2020
@isidorn isidorn added the verification-needed Verification of issue is requested label Mar 9, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Mar 9, 2020

To verify:
make sure to have some files and folders hidden via files.exclude
Open some of the files in an editor. For example via quick open by setting search.exclude to contradict the files.exclude setting
Make sure that while those files are visible in the editor area they are shown in the explorer however they use a dimmed color. As soon as they are no longer visible the explorer no longer shows them.

@isidorn
Copy link
Contributor Author

isidorn commented Mar 10, 2020

Added deemphasize color via 89e1209

@IllusionMH
Copy link
Contributor

files are visible in the editor area

To clarify if I had folder that has a.css.d.ts, b.css.d.ts, ans c.css.d.ts in a folder with other files.

I've opened files a.css.d.ts and b.css.d.ts (tabs in editor), but only a is currently active - should I see only a.css.d.ts in explorer or all open tabs?

Because I think both options are usable, however it's hard to say which will be preferable.

Checked on
VS Code version: Code - Insiders 1.44.0-insider (b7bfce3, 2020-03-17T07:17:39.113Z)
OS version: Windows_NT x64 10.0.18363

Works as expected in files that "hidden" near not excluded files (e.g. *.css.d.ts). Shows 2 or 3 "hidden" files if I have 2 or 3 groups in editor that have them active.

However behavior a bit unexpected for me if I got to definition of React module - whole node_modules folder is expanded (which is huge), @types is expanded, and I can see all files in react folder.

In this example it would be nice to have behavior similar to Compact folders to folder that contains opened file node_modules/@types/react and single index.d.ts (open file) inside.

@isidorn
Copy link
Contributor Author

isidorn commented Mar 17, 2020

@IllusionMH you should only see a.css.d.ts if that is the only one visible.
Agree the other approach also makes sense but for now we went with this.
Let me try to clarify your other point:
Folder A is hidden. You open A/b.txt, and now you see all children of A instead of just b.txt? If this is the case can you please create a new issue and ping me on it. Thank you!

@IllusionMH
Copy link
Contributor

IllusionMH commented Mar 17, 2020

(removed incorrect initial observation)

Looks like color rgb(140, 140, 140) (matches #8C8C8C not sure why it's converted) is applied/removed only after reload, and not when I change true to false false value in files.exclude.

"files.exclude": {
   "**/a1": true
}

Files are shown/hidden immediately.

Issue about nested children is in process.

@isidorn isidorn added on-testplan and removed verification-needed Verification of issue is requested labels Mar 24, 2020
@isidorn isidorn added the on-release-notes Issue/pull request mentioned in release notes label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues on-release-notes Issue/pull request mentioned in release notes on-testplan
Projects
None yet
Development

No branches or pull requests

2 participants