Latest update to 1.43.0 broke color theme "Atom One Dark"

[CombeeMike]

• VSCode Version: 1.43.0
• OS Version: Win 10 v1909

Steps to Reproduce:

1. Download & activate theme Atom One Dark
2. Tokens are colorized different then in previous versions
3. In "side by side" diff view, correct colors are shown on the left side (the original):

Some more observations:

• When activating the theme, it appears "normal" for a moment and changes shortly after
• Same after starting VSCode. The colorization is initially correct and changes once the status message "Initializing JS/TS language features" disappears

Does this issue occur when all extensions are disabled?: No, since the theme is not loaded then ;)

Also happens in fresh installation of VS Code insider with only Atom One Dark extension installed.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Themes crashes and resets to default (#89349)

[themeler]

I've the same problem (Base16 Tomorrow Dark theme). Colors are completly messed up.

[cuddeford]

This is also happening for me with Ruby Blue

[janos-kasa]

This comment helped me: #92308 (comment)

Themes need to be updated to support semantic highlighting.

[cuddeford]

The workaround worked for me

[CombeeMike]

Works for me as well. Am I correct in assuming that the theme maintainer need to update their themes to work with the new semantic highlighting as well?

[cuddeford]

Works for me as well. Am I correct in assuming that the theme maintainer need to update their themes to work with the new semantic highlighting as well?

As far as I can tell, yes. Here's is some reference reading: https://github.com/microsoft/vscode/wiki/Semantic-Highlighting-Overview

[Whitefox98]

Same problem

[rebornix]

thank you all for feedback, let's track this issue in #92308 and for now you can turn off the semantic syntax highlighting feature by changing below setting:

"editor.semanticHighlighting.enabled": false

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!