Replace All Does not work

[yj7]

Version: 1.43.0 (user setup)
Commit: 78a4c91
Date: 2020-03-09T19:47:57.235Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

Steps to Reproduce:

1. Search for a string in the sidebar
2. Open the search in the search editor
3. Change the sidebar from search to search and replace
4. Enter the replace string
5. Replace all does not work

Does this issue occur when all extensions are disabled?: Yes

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• "Replace All" in "Search" tab is a no-op (#91099)

[MythicalFish]

I'm having the same issue on Mac since version 1.43.0
Clicking "Replace all" opens up the new Search Editor, but with none of the results replaced.
I'm able to edit the results but I can't save or apply.

[eladcandroid]

Same issue... Version 1.43.0, OS: Darwin x64 19.3.0

[smuuf]

Same issue, OS Win10 Insiders 19577, working with project inside WSL via Remote-WSL.

Replace All doesn't replace anything.

[ringcrl]

Same issue, OS Win10 Insiders 19577, working with project inside WSL via Remote-WSL.

Replace All doesn't replace anything.

Version: 1.43.0
Commit: 78a4c91
Date: 2020-03-09T19:34:44.548Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.2.0

Same issue

[roblourens]

This works for me. Any idea @JacksonKearl?

Are there any errors in the devtools console? (Help > Toggle Developer Tools)

[JacksonKearl]

I am able to reproduce in Stable and Insiders. Opening the search editor seems to get it into a strange state that isn't resolved until a full reload.

1. Clean workbench. No editors or search widget contents.
2. In vscode repo: search "test all" and put "test none" in replace field
3. Attempt to run replace. Get confirmation message. Decline.
4. Open in editor. Notice the "replace all" button becomes disabled.
5. Run search widget search again, and trigger replace all. No effect.

[roblourens]

I see it. Thanks @JacksonKearl

[PerpetualWar]

same problem here.... after last update, it does nothing, regardless of keyboard shortcut or UI button.

EDIT: after additional restart, it works.

[eladcandroid]

@JacksonKearl
You closed all the duplicate issues and the bug still exists...

[smuuf]

Is this maybe fixed in 1.43.1? I don't see this in list of closed issues.🤔

[eladcandroid]

@smuuf Nope...

[JacksonKearl]

The bug is fixed in insiders. It was not in the recovery build. It will be in the next stable build.