Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextMenu in Editor/Title only available with Tabs active #9247

Closed
alefragnani opened this issue Jul 14, 2016 · 6 comments
Closed

ContextMenu in Editor/Title only available with Tabs active #9247

alefragnani opened this issue Jul 14, 2016 · 6 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@alefragnani
Copy link

  • VSCode Version:1.3.0
  • OS Version: Windows 10

Using the newly available API

Steps to Reproduce:

  1. Add a menu - editor/title entry to package.json
    "menus": {
        "editor/title": [
            {
                "command": "bookmarks.list",
                "group": "bookmarks"
            }
        ]
     }
  1. Turn off showTabs ("workbench.editor.showTabs": false)

The new context menu command is not available. But if you turn on showTabs ("workbench.editor.showTabs": true), the command appears.

Thanks in advance

@jrieken jrieken assigned bpasero and unassigned jrieken Jul 14, 2016
@jrieken
Copy link
Member

jrieken commented Jul 14, 2016

The actions then show in the context menu of the tab... Not nice and an active UX discussion. @bpasero for finding the duplicate of this

@jrieken jrieken added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 14, 2016
@jrieken
Copy link
Member

jrieken commented Jul 14, 2016

screen shot 2016-07-14 at 10 31 46

@jrieken jrieken closed this as completed Jul 14, 2016
@bpasero
Copy link
Member

bpasero commented Jul 14, 2016

@jrieken @alefragnani I am not sure this is the same issue, maybe can you clarify? you say that the actions are not showing up in the context menu if you disable tabs, so this would indicate that the issue is not related to us not showing actions when tabs are enabled.

Today:

  • tabs disabled: all actions show up in the right hand corner
  • tabs enabled: all actions show up on the tab context menu

We plan to change this though to always show all actions int he right hand corner.

@jrieken
Copy link
Member

jrieken commented Jul 14, 2016

screen shot 2016-07-14 at 11 41 23

Well, I see the commands in both cases. Unsure what the issue then is...

@bpasero
Copy link
Member

bpasero commented Jul 14, 2016

There is an edge case where we show a context menu when tabs are disabled and you right click on the title:

image

This might cause some confusion because that menu does not contain the actions contributed.

All this will get much better with: #7666

@alefragnani
Copy link
Author

The issue was related to this edge case. In fact I didn't notice that button in the right hand corner, sorry.

Thank you both for clarifying 👍

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants