Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Jump to Cursor" to "Set Next Statement" #92585

Closed
luabud opened this issue Mar 12, 2020 · 8 comments
Closed

Rename "Jump to Cursor" to "Set Next Statement" #92585

luabud opened this issue Mar 12, 2020 · 8 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@luabud
Copy link
Member

luabud commented Mar 12, 2020

The Python team has received feedback in terms of the Jump to Cursor feature as it's not very discoverable and I believe its name is part of the reason why. Changing it to "Set Next Statement" could make it more discoverable for those who are familiar with the feature. See the comments here for example: microsoft/vscode-python#9947.

@gjsjohnmurray
Copy link
Contributor

What is the "Jump to Cursor" feature? VSCode debug framework has "Run to Cursor", which is not the same thing as I understand a "Set Next Statement" feature.

@rcjsuen
Copy link
Contributor

rcjsuen commented Mar 12, 2020

@gjsjohnmurray I found this in the repository.

export const JUMP_TO_CURSOR_ID = 'debug.jumpToCursor';

From what I understand it's a way to tell the debugger to bypass any intermediate statements and start executing instructions from the selected line.

@luabud
Copy link
Member Author

luabud commented Mar 13, 2020

It's exactly what rcjsuen said 😊

Here's a GIF that shows this in action: https://devblogs.microsoft.com/python/wp-content/uploads/sites/12/2020/02/Feb20-JumpToCursor8.gif

@gjsjohnmurray
Copy link
Contributor

@rcjsuen @luabud thanks for the info. I found the relevant release notes at https://code.visualstudio.com/updates/v1_36#_jump-to-cursor

@isidorn
Copy link
Contributor

isidorn commented Mar 13, 2020

@luabud we decided on Jump to Cursor because the name aligned better with the current Run to Cursor. We were aware that this feature is called Set Next Statement in Visual Studio, however we just prefered the current name.
Changing the name now might break existing users.
What we could do is register the Set Next Statement command in the command palette that would just do the same thing. So we just duplicate it, not the nicest but people who search for it in the command palette would find it.

I am also open for ideas.
fyi @weinand @connor4312

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach labels Mar 13, 2020
@weinand
Copy link
Contributor

weinand commented Mar 13, 2020

We will not change the name but I like Isidor's suggestion to introduce an alias.

The pair of related commands "Run to Cursor" and "Jump to Cursor" sounds more logical (and related) than the pair "Run to Cursor" and "Set next Statement".

@isidorn isidorn closed this as completed in fb28ced Jun 9, 2020
@isidorn isidorn added feature-request Request for new features or functionality verification-needed Verification of issue is requested and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jun 9, 2020
@isidorn isidorn added this to the June 2020 milestone Jun 9, 2020
@isidorn
Copy link
Contributor

isidorn commented Jun 9, 2020

We have added an "alias" for the Jump to Cursor command. The alias is "Set Next Statement'. So now it should be available in the command palette.

@luabud it would be great if you try it with VS Code insiders some time next week and let us know if it works good for you. Thanks

@luabud
Copy link
Member Author

luabud commented Jun 12, 2020

That's awesome, thank you so much! 🎉

@RMacfarlane RMacfarlane added the verified Verification succeeded label Jul 1, 2020
@isidorn isidorn added the on-release-notes Issue/pull request mentioned in release notes label Jul 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants
@weinand @isidorn @RMacfarlane @gjsjohnmurray @rcjsuen @luabud and others