Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scss] support @forward 'library' with syntax #92658

Closed
lekoala opened this issue Mar 13, 2020 · 3 comments · Fixed by gizlang/gizcode-extension-samples#95 · 4 remaining pull requests
Closed

[scss] support @forward 'library' with syntax #92658

lekoala opened this issue Mar 13, 2020 · 3 comments · Fixed by gizlang/gizcode-extension-samples#95 · 4 remaining pull requests
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Milestone

Comments

@lekoala
Copy link

lekoala commented Mar 13, 2020

Version: 1.43.0 (system setup)
Commit: 78a4c91
Date: 2020-03-09T19:47:57.235Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362
(i can also provide extensions but I don't think it really matters in this case)

Steps to reproduce

Open a .scss file
copy paste this

@forward 'library' with (
$black: #222 !default,
$border-radius: 0.1rem !default
);

Expected result : no problems
Actual result:
{
"resource": ".../sass/all.scss",
"owner": "generated_diagnostic_collection_name#0",
"code": "css-unknownkeyword",
"severity": 8,
"message": "unknown keyword",
"source": "scss",
"startLineNumber": 3,
"startColumn": 20,
"endLineNumber": 3,
"endColumn": 24
}

So it seems the sass module system (@use/@Format) should be supported, but the support seem incomplete

The following examples do not work

@forward 'library' with (
  $black: #222 !default,
  $border-radius: 0.1rem !default
);

or

@use 'library' with (
    $black: #222 !default,
    $border-radius: 0.1rem
);

it seems support is missing for:

  • @forward with configuration
  • @use with !default in the configuration (@use with configuration without !default works fine)
@lekoala
Copy link
Author

lekoala commented Mar 13, 2020

Version: 1.43.0 (system setup)
Commit: 78a4c91
Date: 2020-03-09T19:47:57.235Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362
(i can also provide extensions but I don't think it really matters in this case)

Steps to reproduce

  1. Open a .scss file
  2. copy paste this
    @forward 'library' with (
    $black: D language support #222 !default,
    $border-radius: 0.1rem !default
    );

Expected result : no problems
Actual result:
{
"resource": ".../sass/all.scss",
"owner": "generated_diagnostic_collection_name#0",
"code": "css-unknownkeyword",
"severity": 8,
"message": "unknown keyword",
"source": "scss",
"startLineNumber": 3,
"startColumn": 20,
"endLineNumber": 3,
"endColumn": 24
}

@octref octref added bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling and removed info-needed Issue requires more information from poster labels Mar 17, 2020
@octref octref added this to the Backlog milestone Mar 17, 2020
@SharakPL
Copy link
Contributor

Also !default is missing from the suggestions

obraz

@octref octref changed the title sass module syntax support is incomplete Support sass @forward 'library' with syntax Apr 22, 2020
@octref octref assigned aeschli and unassigned octref May 1, 2020
@aeschli aeschli changed the title Support sass @forward 'library' with syntax [scss] support @forward 'library' with syntax May 5, 2020
@aeschli aeschli modified the milestones: Backlog, November 2020 Nov 30, 2020
@sandy081 sandy081 added the verified Verification succeeded label Dec 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.