Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer should sort foo.go before foo_test.go, not after #92662

Closed
peterbourgon opened this issue Mar 13, 2020 · 6 comments
Closed

Explorer should sort foo.go before foo_test.go, not after #92662

peterbourgon opened this issue Mar 13, 2020 · 6 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@peterbourgon
Copy link

peterbourgon commented Mar 13, 2020

Version of VS Code

  • Version: 1.43.0
  • Commit: 78a4c91
  • Date: 2020-03-09T19:34:44.548Z
  • Electron: 7.1.11
  • Chrome: 78.0.3904.130
  • Node.js: 12.8.1
  • V8: 7.8.279.23-electron.0
  • OS: Darwin x64 19.3.0

Your operating system

macOS Catalina 10.15.3

List of extensions that you have installed

  • skyapps.fish-vscode
  • ms-vscode.go
  • adamcaviness.theme-monokai-dark-soda
  • stkb.rewrap
  • rust-lang.rust

Reproducible steps (1... 2... 3...) that cause the issue

When VS Code is opened on a directory, the Explorer pane shows a tree of files rooted in that directory. But the sort order of files that share a prefix is incorrect.

Given a directory with foo.go and foo_test.go, I expect to see

pkg
├── foo
│   ├── foo.go
│   └── foo_test.go

Instead, I see

pkg
├── foo
│   ├── foo_test.go
│   └── foo.go

which is backwards.

What you expected to see, versus what you actually saw

See above.

Images, animations, or a link to a video showing the issue occurring

n/a

A code snippet that demonstrates the issue or a link to a code repository the developers can easily pull down to recreate the issue locally

n/a

Errors from the Dev Tools Console (open from the menu: Help > Toggle Developer Tools)

n/a

@vscodebot
Copy link

vscodebot bot commented Mar 13, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@peterbourgon
Copy link
Author

I've added the missing information.

@gjsjohnmurray
Copy link
Contributor

Is this a duplicate of #27759?

@peterbourgon
Copy link
Author

They are similar, but this issue takes a stricter stance: sort order in this case is well-defined and should not vary by platform.

@isidorn
Copy link
Contributor

isidorn commented Mar 16, 2020

Dup of that one and more explorer sorting issues #27286

@isidorn isidorn closed this as completed Mar 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

4 participants
@peterbourgon @isidorn @gjsjohnmurray and others