Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation popup links are broken #93702

Closed
sguillia opened this issue Mar 29, 2020 · 2 comments
Closed

Documentation popup links are broken #93702

sguillia opened this issue Mar 29, 2020 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) javascript JavaScript support issues typescript Typescript support issues upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone

Comments

@sguillia
Copy link

The links that appear in the documentation popups are broken.
At least for those documenting the VS Code API.

Capture du 2020-03-29 22-50-08

Steps to Reproduce:

  1. Get this vscode demo project in your IDE, open at that line
    https://github.com/microsoft/vscode-extension-samples/blob/0d75c547555a098f8438007c39ca432f819c5354/task-provider-sample/src/customTaskProvider.ts#L95
  2. Put your cursor on createFileSystemWatcher
  3. Click on a link in the "documentation popup" that appears
  4. Observe the error

Version: 1.44.0-insider
Commit: 6cf3dd9
Date: 2020-03-27T05:34:30.255Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 4.15.0-91-generic

Does this issue occur when all extensions are disabled?: Yes

@mjbvz mjbvz self-assigned this Mar 30, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 31, 2020

Consequence of using markdown links for our docs.

We'd like to move to standard JS docs for these links. Upstream issue: microsoft/TypeScript#35524

@mjbvz mjbvz added javascript JavaScript support issues typescript Typescript support issues upstream-issue-linked This is an upstream issue that has been reported upstream labels Mar 31, 2020
@mjbvz mjbvz added this to the Backlog milestone Mar 31, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 31, 2021

Closing this in favor of #120120, which tracks our plan for enabling these links in vscode.d.ts

@mjbvz mjbvz closed this as completed Mar 31, 2021
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 31, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) javascript JavaScript support issues typescript Typescript support issues upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

2 participants