Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test undo stack survival on buffer dispose #93796

Closed
2 tasks done
alexdima opened this issue Mar 30, 2020 · 0 comments
Closed
2 tasks done

Test undo stack survival on buffer dispose #93796

alexdima opened this issue Mar 30, 2020 · 0 comments

Comments

@alexdima
Copy link
Member

alexdima commented Mar 30, 2020

Testing - #7169

Complexity: 3


Please check:

  • open a file
  • make edits to it
  • save the file
  • close the file
  • open the file again
  • undo/redo should work

Extra info / please check:

  • this works only for file and vscode-remote text models.
  • if the undo/redo buffer is very large, a prompt is shown to confirm that storing the memory is OK
  • if the file is edited on disk (while not opened in vscode), when the file is opened the undo/redo buffer is dropped without any prompt by using a content hash.
@alexr00 alexr00 added this to the March 2020 milestone Mar 31, 2020
@sandy081 sandy081 removed their assignment Mar 31, 2020
@alexr00 alexr00 removed their assignment Apr 1, 2020
@alexr00 alexr00 closed this as completed Apr 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants