Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test support for coloring library symbols #93802

Closed
2 tasks done
aeschli opened this issue Mar 30, 2020 · 0 comments
Closed
2 tasks done

Test support for coloring library symbols #93802

aeschli opened this issue Mar 30, 2020 · 0 comments
Assignees
@isidorn
Labels
testplan-item
Milestone
March 2020

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 30, 2020 •
edited by isidorn
Loading

Refs: #91090

Complexity: 2

  • open TypeScipt file
  • open the built-in Monokai theme. The built-in Monokai theme has semantic highlighting enabled and gives different colors to symbols from the default library
  • Use the Developer: Inspect tokens and scopes hover on symbols like Math, Number, Promise, setTimeout
  • verify that the semantic token modifier defaultLibrary is present for these identifiers.
  • verified that the textMate scope for a support.xx rule is picked (not entitiy,name.x)
@aeschli aeschli added this to the March 2020 milestone Mar 30, 2020
@stevencl stevencl removed their assignment Mar 31, 2020
@alexr00 alexr00 assigned isidorn and unassigned btholt Apr 2, 2020
@isidorn isidorn mentioned this issue Apr 2, 2020
Closed
@isidorn isidorn closed this as completed Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
testplan-item
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
4 participants
@btholt @stevencl @isidorn @aeschli