Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow viewdescriptor to take containerName for when they are alone in a custom view container #93972

Closed
sandy081 opened this issue Mar 31, 2020 · 4 comments
Closed

Allow viewdescriptor to take containerName for when they are alone in a custom view container #93972

sandy081 opened this issue Mar 31, 2020 · 4 comments
Assignees
@sbatten
Labels
feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes on-testplan workbench-views Workbench view issues
Milestone
May 2020

Comments

@sandy081
Copy link
Member

Testing #93786

image

image
@sbatten
Copy link
Member

sbatten commented Apr 1, 2020

Should outline have Explorer title when moved outside of Explorer? I think we cannot be consistent and thus we should just do one thing and allow renaming.

@sbatten sbatten added the info-needed Issue requires more information from poster label Apr 1, 2020
@sandy081
Copy link
Member Author

sandy081 commented Apr 1, 2020

I think we can allow an optional additional property on the view descriptor to have generated container name. Debug views then can provide that ?

@sbatten
Copy link
Member

sbatten commented Apr 1, 2020

We allow containerIcon today, so I suppose containerName is analagous?

@sbatten sbatten added feature-request Request for new features or functionality workbench-views Workbench view issues and removed info-needed Issue requires more information from poster labels Apr 1, 2020
@sbatten sbatten added this to the April 2020 milestone Apr 1, 2020
@sbatten sbatten changed the title Debug views should have Debug title when they are moved outside Allow viewdescriptor to take containerName for when they are alone in a custom view container Apr 1, 2020
@sbatten sbatten modified the milestones: April 2020, May 2020 Apr 28, 2020
@sbatten
Copy link
Member

sbatten commented May 11, 2020

allowed by 56b8c19

@sbatten sbatten closed this as completed May 11, 2020
@sbatten sbatten mentioned this issue Jun 1, 2020
Closed
2 tasks
@sbatten sbatten added on-testplan on-release-notes Issue/pull request mentioned in release notes labels Jun 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes on-testplan workbench-views Workbench view issues
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
2 participants
@sbatten @sandy081