Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't click to set/clear breakpoint when a gutter decoration exists #95992

Open
eamodio opened this issue Apr 23, 2020 · 4 comments
Open

Can't click to set/clear breakpoint when a gutter decoration exists #95992

eamodio opened this issue Apr 23, 2020 · 4 comments
Assignees
Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Apr 23, 2020

Here I am using the Bookmarks extension, and you can't click where the bookmark is to set/clear a break point.
image

If I hit F9 to set the break point it works as I would expect, even with the breakpoint indicator on top of the bookmark one.
image

@alefragnani
Copy link

Hi @eamodio ,

This may be somehow related to #5923. I remember in the early days, only one of the decorators where displayed (don’t remember which one) but in recent releases, both are displayed, mixed.

I think the gutter decorators (in this case) should receive similar animation you see in Tree Views, when you do filtering (displayed at its top-right corner). When you move the mouse over that filter, it expands with an additional clear button.

I hope fixing/updating this, would be one step further to deliver #5455 😬

@alefragnani
Copy link

Hi @eamodio ,

The 1.78 release provided some updates on this (https://code.visualstudio.com/updates/v1_78#_glyph-margin-decoration-rendering-improvements), so maybe your issue has been solved.

For me, the Bookmarks are working almost perfectly, with a small issue that I reported here (#181982). It's just a minor detail, and would probably be handled in upcoming releases. I suppose the hardest part has been solved in 1.78, which is great.

Hope this helps

@eamodio
Copy link
Contributor Author

eamodio commented May 10, 2023

@alefragnani Yeah, except for the issue tracked in #181982 it looks like this is resolved.

@hyangah
Copy link

hyangah commented Jan 5, 2024

It looks like we can clear breakpoints, but cannot set new breakpoints on the lines covered with gutter deco.
Is #185814 the blocking task, or is it unrelated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants