-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React-dnd feature is broken within vscode when files are drag and dropped #96770
Comments
(Experimental duplicate detection) |
@egamma : Hi Erich |
Hi Team, |
@mjbvz I don't think this is related to my changes as I've never touched the editor's drag and drop handler. |
This has never been supported as far as I know. I'm closing this as a duplicate of #8794 |
Hi @mjbvz In 1.44.2 version From the below code => it seems to be it creates an overlay within editor part
windowDidDragStart(): void {
windowDidDragStart() {
And in 1.39.2 version you will NOT find the similar kind of codes exist in the respective file https://github.com/microsoft/vscode/blob/1.39.2/src/vs/workbench/browser/parts/editor/editorPart.ts And the one that I have raised is different than the one that you have mentioned as duplicated issue As in this , the user is trying to drag the button within the webview itself , whereas in my case I am trying to drag the items that is part of VSCODE menu items to the EDITOR panel |
Version of vscode
from 1.40 to 1.44.2 versions. The below issue is reproducible
Issue description:
Its not allowing me to drop the file and giving me overlay effect, while dragging the files within vscode and dropping within the editor section, that contains my code related with "React-dnd" library.
Steps to repro
Taken sample code from vscode => webView Sample
<iframe height="500vh" width="100%" sandbox="allow-scripts" nonce="${nonce}" src="${iframesrc}"></iframe>I have modified the code to pick "react-dnd" code within "iframe".
And now on top of that when I try to drag any file within vscode , it doesnt allow me to drop and gives me some overlay effect
Also attaching the Screenshot of the same
expected result should be like below. Allowing files to drop
let me know if any other information is needed regarding the same
The text was updated successfully, but these errors were encountered: