Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding metadata to CellDisplayOutput #97316

Closed
DonJayamanne opened this issue May 8, 2020 · 2 comments
Closed

Allow adding metadata to CellDisplayOutput #97316

DonJayamanne opened this issue May 8, 2020 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

#96433 tracks ability to add metadata to cells, & notebooks.
We also need the ability to add metadata to cell output as well.

Consider the following example:

  • When rendering matplotlibs in Jupyter, the output contains additional metadata useful for rendering.
  • E.g. if a png/svg is returned metadata can be returned in the output indicating whether a white/light background needs to be used.
  • In such a case, a custom renderer for image/png or image/svg+xml will need access to this metadata to wrap the image with a white background container or the like.

@rebornix

@vscodebot
Copy link

vscodebot bot commented May 8, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@rebornix rebornix added feature-request Request for new features or functionality notebook labels Jun 2, 2020
@rebornix rebornix added this to the June 2020 milestone Jun 2, 2020
@rebornix
Copy link
Member

Re #93265 . We now support metadata (and also custom ones) in CellDisplayOutput.

@rebornix rebornix added the verification-needed Verification of issue is requested label Jul 1, 2020
@JacksonKearl JacksonKearl added the verified Verification succeeded label Jul 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@rebornix @DonJayamanne @JacksonKearl and others