"Open Preview to Right" not showing if "Option" key pressed before hovering

[bgashler1]

Regarding #7666 and test item #9701

• VSCode Version: 1.4.0-insider (1.4.0-insider)
• OS Version: macOS El Capitan

Steps to Reproduce:

1. Hold Option key while not hovering over the "Open Preview to Right" command.
2. Then hover over the "Open Preview to Right" command.

Note that it does not change the icon. It only changes when you are already hovering over it and then press the key.

[bgashler1]

Feel free to move to August if it's not worth the risk fixing it quickly.

[isidorn]

Not critical, and since tomorrow is thursday we only fix critical ones -> moving to august

[jrieken]

@bgashler1 Sure about the Option key? This implementation is about alt as in alternative command. I would not expect option to ever work

[bgashler1]

@jrieken When I say Option, I also mean the Alt key.

When your cursor is already over this button and you press either of these keys (depending on your platform), the alternate action and its icon appear (i.e. "Open Preview to the Side").

The issue is that it does not appear as expected if you are already holding down the key before you hover over.

[jrieken]

Thanks, understood.