Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cross-file undoing in files that were closed #98987

Closed
2 tasks done
alexdima opened this issue Jun 1, 2020 · 2 comments
Closed
2 tasks done

Test cross-file undoing in files that were closed #98987

alexdima opened this issue Jun 1, 2020 · 2 comments

Comments

@alexdima
Copy link
Member

alexdima commented Jun 1, 2020

Test plan item for #92272

Complexity: 3

Create Issue


  • Create a cross-file edit that involves file edits (not file renames), like a rename in a TS file.
  • Close some of the files
  • In one of the edited file, do an undo
  • The closed files should now reopen and the undo should be applied in all of them

There are some special cases like renaming or editing files on disk before undoing. Please check that things work OK.

@sbatten
Copy link
Member

sbatten commented Jun 2, 2020

The closed files should now reopen and the undo should be applied in all of them

The files do not reopen but the undo is applied, I'll assume this is intentional

@connor4312
Copy link
Member

connor4312 commented Jun 2, 2020

Last week I renamed a function and undid it, which ended up clobbering files giving some broken name. I wasn't able to get a repro for it then or now, but fyi.

@connor4312 connor4312 removed their assignment Jun 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants