Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find all references are not sorted by cell #99152

Closed
sandy081 opened this issue Jun 2, 2020 · 2 comments
Closed

Find all references are not sorted by cell #99152

sandy081 opened this issue Jun 2, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook references-viewlet verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 2, 2020

Testing #98821

Kapture 2020-06-02 at 19 06 34

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug notebook references-viewlet labels Jun 3, 2020
@jrieken jrieken added this to the May 2020 milestone Jun 3, 2020
@jrieken
Copy link
Member

jrieken commented Jun 3, 2020

Yeah, this is the usual sort bug, e.g 1, 10, 11, 12, 2, 3

@jrieken jrieken closed this as completed in ceb87a1 Jun 3, 2020
@jrieken
Copy link
Member

jrieken commented Jun 3, 2020

Cell fragments are now padded with zeros so that natural sort works againt. This is kinda lame but works...

@sandy081 sandy081 added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook references-viewlet verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants
@jrieken @sandy081 and others