Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant entries in Find all references view #99153

Closed
sandy081 opened this issue Jun 2, 2020 · 2 comments
Closed

Redundant entries in Find all references view #99153

sandy081 opened this issue Jun 2, 2020 · 2 comments
Assignees
@jrieken
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code references-viewlet under-discussion Issue is under discussion for relevance, priority, approach
Milestone
Backlog

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 2, 2020

Testing #98821

  • Open My Work notebook
  • Find all references for $vscode
  • Rename $vscode to $vscoderepo
  • clear results in references view
  • click on refresh action on $vscode entry in references view
  • clear results again

🐛 Two entries are shown now which are pointing to same

image
@jrieken jrieken added feature-request Request for new features or functionality references-viewlet under-discussion Issue is under discussion for relevance, priority, approach labels Jun 3, 2020
@jrieken jrieken added this to the Backlog milestone Jun 3, 2020
@jrieken
Copy link
Member

jrieken commented Jun 3, 2020

Yeah, not so simple but independent of notebooks. The viewlet doesn't know anything about "anchor symbols" but simply remembers words at certain locations. It would need some de-dupe based on the location

@jrieken jrieken added the *out-of-scope Posted issue is not in scope of VS Code label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code references-viewlet under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jrieken @sandy081 and others