Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"stopAll" ends debugging after the second "attach" config is disconnected #99299

Closed
roblourens opened this issue Jun 3, 2020 · 3 comments
Closed
Assignees
Milestone

Comments

@roblourens
Copy link
Member

  • Start the "VS Code" compound config
  • Detach "Attach to Main Process"
  • Everything else is still attached
  • Detach "Attach to Shared Process"
  • All the remaining configs are stopped

Same thing if I do the 2 in the opposite order so I don't think it's anything special about the Shared Process. Is it all supposed to shut down after one attach config is detached, or should it only shut down when a launch config is stopped?

Jun-03-2020 12-11-36

@connor4312
Copy link
Member

I believe this is because the "main process" you have selected is actually the child session of the main process. Terminating that causes the parent session to exit, but I've set it up so that stopAll only bubbles explicit exits from the user.

For attachment, though, it should be totally safe to forego the parent session. I'll look at getting rid of that.

@connor4312
Copy link
Member

Actually I will pause on this for #99736

@kieferrm kieferrm modified the milestones: June 2020, July 2020 Jul 6, 2020
@connor4312
Copy link
Member

I've since modified stopAll to tell all targets to stop whenever any target, not just a parent, is stopped.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants