Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a good example for using 'setState' in NotebookRendererApi #99300

Closed
miguelsolorio opened this issue Jun 3, 2020 · 1 comment
Closed
Assignees

Comments

@miguelsolorio
Copy link
Contributor

Testing #99001

Maybe this is just my lack of understand with the notebook API, but all of the other methods in INotebookRendererApi seem to have clear instructions on what they're used for (onWillDestroyCell and onDidCreateCell are good examples). But for setState and getState I'm a bit unsure of how i'm suppose to use this. It seems as if once I set this in the entry point for the renderer the state is persisted, so this makes it a bit ambiguous on its use. Maybe if there was a good example for this.

@connor4312
Copy link
Member

Thanks, merging into #99320. I want to move those types from a copypasta'd .d.ts into its own package with appropriate documentation 🙂

@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants