Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening notebook for first time fails on VSCode Insiders #99382

Closed
DonJayamanne opened this issue Jun 4, 2020 · 4 comments
Closed

Opening notebook for first time fails on VSCode Insiders #99382

DonJayamanne opened this issue Jun 4, 2020 · 4 comments
Assignees
Labels
*caused-by-extension Issue identified to be caused by an extension notebook
Milestone

Comments

@DonJayamanne
Copy link
Contributor

  • Version: 1.46.0-insider
  • OS: Windows

Screen Shot 2020-06-04 at 08 59 45

Steps to Reproduce:

1.When opening an ipynb file in using the Python extension and VS COde Notebooks API, windows user always gets an error
2.Below is the error log. Opening the file again works.
3. Unable to repro on Mac (3 users), but always reproducible on Windows.

Log ``` [Yesterday 11:02 AM] Jim Griesmer To be clearer: console.ts:137 [Extension Host] (node:148856) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. (at writeOut (internal/process/warning.js:27:3))t.log @ console.ts:137 $logExtensionHostMessage @ mainThreadConsole.ts:39 _doInvokeHandler @ rpcProtocol.ts:402 _invokeHandler @ rpcProtocol.ts:387 _receiveRequest @ rpcProtocol.ts:303 _receiveOneMessage @ rpcProtocol.ts:230 (anonymous) @ rpcProtocol.ts:105 fire @ event.ts:587 fire @ ipc.net.ts:453 _receiveMessage @ ipc.net.ts:733 (anonymous) @ ipc.net.ts:592 fire @ event.ts:587 acceptChunk @ ipc.net.ts:239 (anonymous) @ ipc.net.ts:200 t @ ipc.net.ts:28 emit @ events.js:203 addChunk @ _stream_readable.js:295 readableAddChunk @ _stream_readable.js:276 Readable.push @ _stream_readable.js:210 onStreamRead @ internal/stream_base_commons.js:166 notificationsAlerts.ts:40 Unable to open 'RunByLine.ipynb': Cannot open notebook of type 'jupyter-notebook'. onDidChangeNotification @ notificationsAlerts.ts:40 (anonymous) @ notificationsAlerts.ts:26 fire @ event.ts:587 addNotification @ notifications.ts:207 notify @ notificationService.ts:106 doHandleOpenEditorError @ editorGroupView.ts:1056 (anonymous) @ editorGroupView.ts:984 processTicksAndRejections @ internal/process/task_queues.js:85 async function (async) (anonymous) @ editorGroupView.ts:973 doShowEditor @ editorGroupView.ts:971 doOpenEditor @ editorGroupView.ts:954 openEditor @ editorGroupView.ts:882 openEditor @ editorService.ts:530 onEditorOpening @ notebook.contribution.ts:327 open @ notebook.contribution.ts:160 onGroupWillOpenEditor @ editorService.ts:509 (anonymous) @ editorService.ts:165 fire @ event.ts:587 openEditor @ editorGroupView.ts:875 (anonymous) @ editorService.ts:1299 (anonymous) @ explorerViewlet.ts:218 openEditor @ editorService.ts:1298 (anonymous) @ explorerView.ts:429 fire @ event.ts:587 open @ listService.ts:542 onSelection @ listService.ts:537 (anonymous) @ listService.ts:498 fire @ event.ts:587 (anonymous) @ event.ts:56 (anonymous) @ event.ts:810 fire @ event.ts:587 _set @ abstractTree.ts:1020 set @ abstractTree.ts:1010 setSelection @ abstractTree.ts:1219 onPointer @ listWidget.ts:634 onPointer @ abstractTree.ts:1138 fire @ event.ts:589 (anonymous) @ event.ts:56 fire @ event.ts:587 o @ event.ts:16 Show 10 more frames notificationsAlerts.ts:40 Unable to open 'RunByLine.ipynb': Cannot open notebook of type 'jupyter-notebook'. (1 liked) ```

Does this issue occur when all extensions are disabled?: No

@rebornix /cc

@DonJayamanne
Copy link
Contributor Author

@rebornix I'm not on a Windows PC, I'm on a Mac and do not see this issue at all.
Will try to setup a Windows PC to see if I can repro this. However based on the error logs, the errors are coming from the VS Code (not extension) & it oddly enough it works without any issues on Macs.

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook labels Jun 9, 2020
@rebornix rebornix added this to the June 2020 milestone Jun 9, 2020
@DonJayamanne
Copy link
Contributor Author

Apologies , this is a bug at our end.
Sorry for wasting your time @rebornix

@rebornix
Copy link
Member

rebornix commented Jun 9, 2020

@DonJayamanne no worries.

What happened in this case is we try to activate Python extension when opening a .ipynb file but the activate method returns before the content provider for .ipynb file is registered so the core fails as it doesn't find any provider for the notebook.

@rebornix rebornix added *caused-by-extension Issue identified to be caused by an extension and removed bug Issue identified by VS Code Team member as probable bug labels Jun 9, 2020
@heychazza
Copy link

I also have this issue, https://pastebin.com/zSVZLcPX any eta for a fix? I rely on this :(

@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*caused-by-extension Issue identified to be caused by an extension notebook
Projects
None yet
Development

No branches or pull requests

3 participants