Cannot read property 'start' of undefined: TypeError: Cannot read property 'start' of undefined

[StephenWeatherford]

Issue Type: Bug

Seeing this frequently in my pipeline builds (e.g. https://dev.azure.com/ms-azuretools/AzCode/_build/results?buildId=20513&view=logs&j=a5e52b91-c83f-5429-4a68-c246fc63a4f7&t=95359773-9cfc-583f-7b87-0a0d44ca7da9&l=769). Have occasionally see it locally, but don't have a repro scenaro.

Pretty sure this is not in my code.

VS Code version: Code - Insiders 1.46.0-insider (595d2b9, 2020-06-03T05:38:33.098Z)
OS version: Darwin x64 18.7.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	2, 2, 3
Memory (System)	16.00GB (0.67GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (11)

Extension	Author (truncated)	Version
vscode-azurestorage	ms-	0.9.0
vscode-azurevirtualmachines	ms-	0.1.0
vscode-cosmosdb	ms-	0.13.0
vscode-docker	ms-	1.2.1
csharp	ms-	1.22.0
vscode-dotnet-runtime	ms-	0.1.2
azure-account	ms-	0.8.11
vscode-typescript-tslint-plugin	ms-	1.2.3
vscode-yaml	red	0.8.0
tmcolor	sle	0.0.1
vscode-todo-highlight	way	1.0.4

[StephenWeatherford]

intersection(t){const i=v.Max(t.start,this._start)

[alexdima]

vscode/src/vs/workbench/api/common/extHostLanguageFeatures.ts

Line 390 in 3367698

if (ran.intersection(diagnostic.range)) {

[StephenWeatherford]

Thanks for the pointer, allowed me to find the issue - our language server was returning some Diagnostics with a null Range. This wasn't a problem for publishing errors to the diagnostics collection, that code was tolerant of this and this code has been like this a long time.

What triggered the error is that we started implementing provideCodeActions in the TypeScript (completely separate from our language server, which is a C# LSP), and that code in vscode didn't handle the null ranges in the diagnostics collection. Seems like this could trip other extensions even...

I've fixed our code, but I recommend that you either sanitize the range when they're pushed to a diagnostics collection teach the code actions code to be tolerant of a null range. Thanks!

[mjbvz]

@sandy081 Assigning you since it sounds like we may want to validate diagnostics before adding them to the diagnostic collection

[sandy081]

This seems to be in diagnostics API so moving to @jrieken

[jrieken]

creating diagnostics without range or message now throws a type error

[StephenWeatherford]

Thx

[isidorn]

Adding verified based on code review