Unify colors of find in file and workspace search results

[chrmarti]

• VSCode Version: Code - Insiders 1.4.0-insider (4656fe3, 2016-07-29T05:03:52.605Z)
• OS Version: Darwin x64 15.5.0

Find in file (Ctrl+F) and workspace search (Ctrl+Shift+F) results are colored not exactly the same. It might be easier to read the color-coding if it was the same.

Local search:

Global search:

Note the different browns for the results and the different renderings of the current line in the two cases.

(Extracted from #6402.)

[sandy081]

This happens when both Search and Find are active on file for the same term. Otherwise they are similar in colors for results. If both are active then each adds same decoration and there are two overlay decoration on the same word which is causing a different color. One soultion for this could be to disallow duplicate decorations but I think this is complex as state is going to be involved. Also it has to be dealt properly when a decoration is removed.

IMO the current behavior is reasonable.

It leaves to the issue about Search selecting the line of current find result. I will create a separate issue for that and leave this issue only for search and find results color.

[octref]

Since this is as-designed, there isn't anything to verify.
I'm adding the verified tag and removing bug.
@sandy081 Let me know if I'm doing it wrong.

[Tyriar]

Related discussion: #11354