Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump node-pty@0.9.0-beta19 #77251

Merged
merged 1 commit into from
Jul 12, 2019
Merged

chore: Bump node-pty@0.9.0-beta19 #77251

merged 1 commit into from
Jul 12, 2019

Conversation

deepak1556
Copy link
Collaborator

  • Fixes compilation under windows for electron 6

@deepak1556 deepak1556 added this to the July 2019 milestone Jul 11, 2019
@deepak1556 deepak1556 requested a review from Tyriar July 11, 2019 22:46
@deepak1556 deepak1556 self-assigned this Jul 11, 2019
Tyriar
Tyriar approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once CI passes, thanks for this 👌

@deepak1556 deepak1556 merged commit 3456ef3 into master Jul 12, 2019
@deepak1556 deepak1556 deleted the bump_node_pty branch July 12, 2019 00:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
July 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@deepak1556 @Tyriar