Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSIX files are different between file service and CDN downloads #1058

Open
dtivel opened this issue Oct 31, 2024 · 5 comments
Open

VSIX files are different between file service and CDN downloads #1058

dtivel opened this issue Oct 31, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@dtivel
Copy link
Member

dtivel commented Oct 31, 2024

Describe the bug
Downloading the same version of veracode.veracode-vscode-plugin 1.11.5 from both the VS Marketplace file service and CDN yields different files.

To Reproduce
Steps to reproduce the behavior:

  1. Open a PowerShell prompt and execute:
curl -L https://veracode.gallerycdn.vsassets.io/extensions/veracode/veracode-vscode-plugin/1.11.5/1729772595143/Microsoft.VisualStudio.Services.VSIXPackage -o ./cdn.vsix
curl -L https://veracode.gallery.vsassets.io/_apis/public/gallery/publisher/Veracode/extension/veracode-vscode-plugin/1.11.5/assetbyname/Microsoft.VisualStudio.Services.VSIXPackage?targetPlatform=darwin-arm64 -o gallery.vsix

$cdnHash = (Get-FileHash './cdn.vsix').Hash
$cdnSize = (Get-Item './cdn.vsix').Length
$galleryHash = (Get-FileHash './gallery.vsix').Hash
$gallerySize = (Get-Item './gallery.vsix').Length

$results = @(
    [PSCustomObject]@{FileName='cdn.vsix'; Hash=$cdnHash; Size=$cdnSize},
    [PSCustomObject]@{FileName='gallery.vsix'; Hash=$galleryHash; Size=$gallerySize}
)

$results | Format-Table -Property FileName, Hash, Size -AutoSize

Expected behavior
File hashes will be identical.

Actual behavior
The files are different.

FileName     Hash                                                                 Size
--------     ----                                                                 ----
cdn.vsix     F60A1359F1BDCDC3801808A01EBCE5056FE68527CAB76F0636420EA44E2677A7 14613661
gallery.vsix 2AF60BFE2215E4C5DAE4B233BA37AB98220E070E1B599260E258A73F4D7E4F06 14613651

CC @isidorn, @joaomoreno, @sandy081, @seaniyer

@dtivel dtivel added the bug Something isn't working label Oct 31, 2024
@dtivel
Copy link
Member Author

dtivel commented Oct 31, 2024

Related to #619

@isidorn
Copy link
Collaborator

isidorn commented Nov 1, 2024

I hoped we fixed this issue. @dtivel do you have any leads on why this might be happening?
I noticed the extension in question is a platform specific extension. I do not know if that is related.

also fyi @drewgillies

@sbanni
Copy link

sbanni commented Nov 1, 2024

Its a different package, the package from the CDN has the pre-release flag:
<Property Id="Microsoft.VisualStudio.Code.PreRelease" Value="true" />

@dtivel @isidorn

@isidorn
Copy link
Collaborator

isidorn commented Nov 1, 2024

Thanks. So looks like we can close this one as designed?

@dtivel
Copy link
Member Author

dtivel commented Dec 2, 2024

No, we should not close this as by design. I chatted with @sbanni. My understanding is that he was showing how the 2 extension files differ, and he is correct. However, more importantly, at this time they should not differ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants