Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't there be a restriction on displayName length and other fields in the extension manifest? #107

Closed
Tracked by #154
sandy081 opened this issue Jun 23, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@sandy081
Copy link
Member

Initially filed by @aravindvnair99 here - microsoft/vscode#126771

Does this issue occur when all extensions are disabled?: No

  • VS Code Version: 1.57.1
  • OS Version: Windows 10 21H1 19043.1052

Steps to Reproduce:

  1. Install Tabnine AI Code Completion for all major programming languages, autocomplete JavaScript, Python, TypeScript, PHP, Go, Java, Ruby, C/C++, HTML/CSS, C#, Rust, SQL, Bash, Kotlin, React, Swift, Scala, Sass, Perl, Objective C, Node JS, Matlab, Haskell, Dart, Angular extension.
  2. Open Running Extensions or Extension panel to end up with these:
  • Unable to see activation time in Visual Studio Code - Running Extensions:
    image

  • Name not completely visible in Visual Studio Code - Extension panel
    image

I did report to the authors at codota/tabnine-vscode#535 and also gave them a PR for the same at codota/tabnine-vscode#536 which they have closed by saying:

we use longer names to make it easier for people to find Tabnine in the search results.

I understand that, but shouldn't there be a restriction on displayName length from Visual Studio Code itself to prevent authors from using whatever length they feel like? As then I would not end up with the scenario as shown in the screenshot, especially I not being able to view the activation time.

On a side note, I also feel not imposing length or quantity restrictions for items in the extension manifest leads to abuse and unfair competition. I strongly feel this should be regulated so that all extensions have equal visibility and opportunity to grow their user base and not based on who adds more things in the fields. Right now, I see only the following two restrictions:

Name Type Details
description string A short description of what your extension is and does.
keywords array An array of keywords to make it easier to find the extension. These are included with other extension Tags on the Marketplace. This list is currently limited to 5 keywords.

But short is subjective. Short to you is different from short to me. I feel there should be a well-defined maximum number. And likewise, for keywords, I see many extensions using more than 5 keywords including the one I mentioned which is using 34 keywords.

Other fields don't have restrictions at all.

@sandy081 sandy081 added the bug Something isn't working label Jun 23, 2021
@sandy081
Copy link
Member Author

It seems authors are adding such long titles for better discoverability. I do not think we shall encourage authors to come up with such hacks for discoverability. Is it possible to place some restrictions for such usages?

@RandomFractals
Copy link

I disagree on the keywords part. Please don't do that. Search in marketplace is broken as is.

Please fix that first!

Thanks

@eamodio
Copy link

eamodio commented Jun 23, 2021

💯 Agree -- Marketplace search needs to be fixed before anything here should be changed imo.

@aravindvnair99
Copy link

@sandy081 @prashantvc any updates?

@prashantvc prashantvc added this to the Planned milestone Aug 25, 2021
@prashantvc
Copy link
Contributor

like everyone mentioned it is an issue with search, and people optimising their extension to show up on the top.
As we improve the search, we hope extension authors will stop doing this.

We will evaluate this later, while we deploy search improvements. I am closing this issue for now

@xavierdecoster xavierdecoster removed this from the Planned milestone Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants