Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace extension page hava a problem with displaying the markdown table when without &ssr=false param. #883

Open
ygqygq2 opened this issue Mar 22, 2024 · 5 comments
Assignees
Labels
bug Something isn't working triaged

Comments

@ygqygq2
Copy link

ygqygq2 commented Mar 22, 2024

Without &ssr=false

https://marketplace.visualstudio.com/items?itemName=ygqygq2.turbo-file-header
image

With &ssr=false

https://marketplace.visualstudio.com/items?itemName=ygqygq2.turbo-file-header&ssr=false#overview
image

@sandy081 sandy081 transferred this issue from microsoft/vscode Apr 9, 2024
@sandy081 sandy081 removed their assignment Apr 9, 2024
@madhurivadaligithub
Copy link

Hi @ygqygq2

Thank you for reaching VS Marketplace Team. We are looking into the issue and will get back to you with an update.

-VS Marketplace Team

@agr
Copy link

agr commented May 9, 2024

Apologies for the late response. There might be a bug in the marketplace SSR code that converts markdown to HTML. It seems to be triggered by empty code blocks in your table:
image
As a mitigation, I'd suggest to try to remove those from your table. Please, let me know if that helps.

@ygqygq2
Copy link
Author

ygqygq2 commented May 9, 2024

@agr
Copy link

agr commented May 9, 2024

There is a bug, fixing it will take some time. If you want your table to look nice in both cases now, I suggested a workaround. Feel free to wait until the bug is fixed though.

@agr
Copy link

agr commented May 9, 2024

I've been pointed out that double backticks do not denote an empty code span, but opening a code span where single backticks are ignored. So, what happens here is that double backtick in the first row opens a code span which lasts until another double backtick in the second row. Which in turn destroys any chance of parsing table as table and it seems to be the correct behavior here, although counterintuitive.

@madhurivadaligithub madhurivadaligithub added bug Something isn't working triaged labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged
Projects
None yet
Development

No branches or pull requests

5 participants