Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package inserted into CLI should not include dependencies #1886

Closed
nguerrera opened this issue Jan 7, 2019 · 3 comments
Closed

Package inserted into CLI should not include dependencies #1886

nguerrera opened this issue Jan 7, 2019 · 3 comments

Comments

@nguerrera
Copy link

See dotnet/toolset#70

These files are in the package that come from other repos (newtonsoft.json, core-setup, corefx).

NewtonSoft.Json.dll;
Microsoft.DotNet.PlatformAbstractions.dll;
Microsoft.Extensions.DependencyModel.dll;
System.Xml.XPath.XmlDocument.dll

cc @livarcocc

@mayankbansal018
Copy link
Contributor

@nguerrera we simply drop dependencies present in this package to dotnet, however as the issue says dotnet sdk already brings these along, which are also latest in revision.

Can you provide some mechanism by which we can make sure that what ever additional dependencies we have, like those mentioned above, are getting packaged into dotnet sdk, & if not then only we drop those explicitly via our nuget.

One way I could of is by, rather can including these dll in contentFiles, & copying them, we take dependency on their respective nuget packages, but I'm not sure if that will make sure that those files get dropped if needed?

@mayankbansal018
Copy link
Contributor

@nguerrera , any suggestions here please?

@nguerrera
Copy link
Author

nguerrera commented Jun 4, 2019

What other inserters to the root CLI directory do is provide a package with genuine runtime assets and dependencies and dependencies on other things, instead of putting dlls in the content folder. We can then let nuget resolve the right version. Look at https://www.nuget.org/packages/Microsoft.Build.Runtime/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants