Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test template for netcoreapp1.0 TFM in dotnet/sdk repo. #230

Closed
harshjain2 opened this issue Nov 16, 2016 · 2 comments
Closed

Update test template for netcoreapp1.0 TFM in dotnet/sdk repo. #230

harshjain2 opened this issue Nov 16, 2016 · 2 comments

Comments

@harshjain2
Copy link
Contributor

Description

For netcoreapp1.0 TFM, Output Type should be Exe. Corresponding change should be made in https://github.com/dotnet/sdk repo here

Change

<OutputType Condition=" '$(TargetFramework)' == 'netcoreapp1.0' ">Exe</OutputType>

@codito
Copy link
Contributor

codito commented Nov 17, 2016

@harshjain2 the default template already has the following

<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp1.0</TargetFramework>

Did you mean add support for net46 as well?

<OutputType Condition=" '$(TargetFramework)' == 'netcoreapp1.0' ">Exe</OutputType>
<OutputType Condition=" '$(TargetFramework)' == 'net46' ">Library</OutputType>
<TargetFrameworks>net46;netcoreapp1.0</TargetFrameworks>

@codito
Copy link
Contributor

codito commented Dec 21, 2016

Closing this in favor of #287. We'll add conditional OutputType to Microsoft.NET.Test.Sdk.

@codito codito closed this as completed Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants