Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.TestPlatform.ObjectModel packages the wrong dlls #2458

Closed
dfederm opened this issue Jun 9, 2020 · 2 comments
Closed

Microsoft.TestPlatform.ObjectModel packages the wrong dlls #2458

dfederm opened this issue Jun 9, 2020 · 2 comments

Comments

@dfederm
Copy link
Member

dfederm commented Jun 9, 2020

Description

The Microsoft.TestPlatform.ObjectModel package has netcoreapp2.1 dlls in the netstandard2.0 folder.

Steps to reproduce

N/A

Expected behavior

The dlls in the netstandard2.0 dir target netstandard2.0

Actual behavior

The dlls in the netstandard2.0 dir target netcoreapp2.1

image

@dfederm
Copy link
Member Author

dfederm commented Jun 9, 2020

It looks like this is due to the nuspec specifying $NetCoreTargetFramework$:

<file src="$NetCoreTargetFramework$\Microsoft.VisualStudio.TestPlatform.ObjectModel.dll" target="lib\netstandard2.0\" />
<file src="$NetCoreTargetFramework$\Microsoft.TestPlatform.CoreUtilities.dll" target="lib\netstandard2.0\" />
<file src="$NetCoreTargetFramework$\Microsoft.TestPlatform.PlatformAbstractions.dll" target="lib\netstandard2.0\" />

Which from looking at the build scripts is netcoreapp2.1

$TPB_TargetFrameworkCore20 = "netcoreapp2.1"

@Evangelink Evangelink added the needs-triage This item should be discussed in the next triage meeting. label Jul 25, 2022
@Evangelink
Copy link
Member

This is now fixed.

@Evangelink Evangelink removed the needs-triage This item should be discussed in the next triage meeting. label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants