Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.NET.Test.Sdk 17.10 breaks MSBuild isolation #5190

Open
hotchkj opened this issue Aug 28, 2024 · 1 comment
Open

Microsoft.NET.Test.Sdk 17.10 breaks MSBuild isolation #5190

hotchkj opened this issue Aug 28, 2024 · 1 comment
Assignees

Comments

@hotchkj
Copy link

hotchkj commented Aug 28, 2024

Description

Building any test project with Microsoft.NET.Test.Sdk 17.10.0 or 17.11.0 against MSBuild with the isolate flag on breaks the build. This suggests the package is doing something that it should not be in MSBuild tasks, since isolation is expected to succeed with 'normal' managed projects. This did not apply with 17.9 or earlier, thus appears to be a regression.

Steps to reproduce

  • Create a sample pair of csproj, one src and one test, targeting NET 6 & NET 8
    • No source is required, just the replicating csproj files
  • Reference Microsoft.NET.Test.Sdk 17.10 in the test project as PackageReference
  • Reference the other project src as a ProjectReference in the test project
  • Build the pair of projects as a solution with msbuild /target:Rebuild -isolateProjects:true -graphBuild:true

Expected behavior

The build succeeds.

Actual behavior

The build fails with isolation errors, indicating that the global properties set for each project have been altered during the build.

Workaround

Revert to Microsoft.NET.Test.Sdk 17.9.0, or change to -isolateProjects:false, removing build isolation

Diagnostic logs

N/A - build issue not test issue.

Environment

Windows 10, MSBuild 17.10.4

@nohwnd
Copy link
Member

nohwnd commented Aug 29, 2024

Thanks for reporting, I will investigate.

@nohwnd nohwnd self-assigned this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants